@W-20161521: remove basket refetch after mergeBasket call#3472
Merged
dannyphan2000 merged 2 commits intofeature/1cc_paymentsfrom Nov 14, 2025
Merged
Conversation
Signed-off-by: d.phan <d.phan@salesforce.com>
dannyphan2000
added
the
skip changelog
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| }) | ||
| const mergedBasketId = merged?.basketId | ||
| const refreshedBasketId = await currentBasketQuery.refetch() | ||
| basketId = refreshedBasketId?.data?.basketId || mergedBasketId || basket.basketId |
Collaborator
There was a problem hiding this comment.
If merge basket fails for whatever reason, then we don't have a basket in context to go further. We should at least keep the basket.basket.Id if we feel strongly about removing the basket refetch.
Signed-off-by: d.phan <d.phan@salesforce.com>
syadupathi-sf
approved these changes
Nov 14, 2025
dannyphan2000
deleted the
dannyphan2000.W-20161521.remove-refetch-not-needed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove basket refetch after mergeBasket call
Description
Remove basket refetch after mergeBasket call
Types of Changes
Changes
How to Test-Drive This PR
Follow 1CC user scenario.
Checklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization